Remove mention of FTP in ContentParent
Categories
(Core :: Networking, task, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox126 | --- | fixed |
People
(Reporter: manuel, Assigned: mika.valkealahti, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [necko-triaged][necko-contribution])
Attachments
(1 file)
/dom/ipc/ContentParent.h#554,559
// HTTP(S) or FTP channel for a content process. It is a useful place
...
nsresult AboutToLoadHttpFtpDocumentForChild(
Nowadays, we only load HTTP(S). Since it is only about removing the mention (editing comment + renaming function). This is a good bug for trying out or getting used to the submit patch toolchain.
Not putting into this bug into Core :: Networking: FTP component, due to the component being removed soon.
| Assignee | ||
Comment 1•3 months ago
|
||
Hi!
First timer here :)
I would like to take this one since it sounds rather simple. I already made a bit research and found that function is mentioned in following files
dom/ipc/ContentParent.h
dom/ipc/ContentParent.cpp
dom/localstorage/LocalStorageManager2.cpp
dom/localstorage/nsILocalStorageManager.idl
dom/localstorage/PBackgroundLSDatabase.ipdl
netwerk/protocol/http/HttpChannelParent.cpp
but only tha part what you mentioned and these two
dom/ipc/ContentParent.cpp
netwerk/protocol/http/HttpChannelParent.cpp
has that function call others have just comments.
"This is a good bug for trying out or getting used to the submit patch toolchain." --> This is exactly why I am interested about this so I would have better picture how this whole workflow goes since fix is rather simple but first time when I am trying to enter whole process
| Reporter | ||
Comment 2•3 months ago
•
|
||
Sure, submitting a patch will automatically get you assigned.
Here is a searchfox query showing all uses of the function: https://searchfox.org/mozilla-central/search?q=AboutToLoadHttpFtpDocumentForChild&redirect=false.
| Assignee | ||
Comment 3•3 months ago
|
||
Updated•3 months ago
|
| Assignee | ||
Comment 4•3 months ago
|
||
Hi Manuel!
I made changes and they should be now waiting for review https://phabricator.services.mozilla.com/D204850
I added you as reviewer since I thought it would make sense. Small change and you were reporter and knew exactly where I should look at :)
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3af527ac9ec3 Renaming functions and renaming comments mentions related to them r=necko-reviewers,kershaw
Comment 6•3 months ago
|
||
| bugherder | ||
Description
•