Firefox fails to compile in non-unified builds
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox126 fixed)
| Tracking | Status | |
|---|---|---|
| firefox126 | --- | fixed |
People
(Reporter: amit.prakash.ambasta, Assigned: amit.prakash.ambasta)
Details
Attachments
(5 files)
|
726 bytes,
patch
|
Details | Diff | Splinter Review | |
|
805 bytes,
patch
|
Details | Diff | Splinter Review | |
|
825 bytes,
patch
|
Details | Diff | Splinter Review | |
|
1.38 KB,
patch
|
Details | Diff | Splinter Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:124.0) Gecko/20100101 Firefox/124.0
Steps to reproduce:
Build w/ system-icu and without unified builds
mozconfig_add_options_ac '--disable-unified-build' --disable-unified-build
mozconfig_add_options_ac '--with-system-icu' --with-system-icu
...
./mach build
Actual results:
Multiple build failures due to missing imports
MOZ_TRY in intl/components/src/TimeZone.h
cstddef in layout/style/PseudoStyleType.h
mozilla/WidgetUtilsGtk.h in widget/gtk/GtkCompositorWidget.h
DocAccessible-inl.h in accessible/html/HTMLTableAccessible.cpp
Expected results:
Build should succeed
| Assignee | ||
Comment 1•2 months ago
|
||
Patch for missing headers for size_t
Comment 2•2 months ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Disability Access APIs' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
| Assignee | ||
Comment 3•2 months ago
|
||
Missing headers for MOZ_TRY in TimeZone.cpp
| Assignee | ||
Comment 4•2 months ago
|
||
Missing header for GdkIsWaylandDisplay in widget/gtk/GtkCompositorWidget.cpp
| Assignee | ||
Comment 5•2 months ago
|
||
Missing header for DocAccessible::FireDelayedEvent in accessible/html/{HTMLSelectAccessible,HTMLTableAccessible}.cpp
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 6•2 months ago
|
||
Patch 1 has already landed in gecko-dev due to #1882942
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 7•2 months ago
|
||
Signed-off-by: Amit Prakash Ambasta <amit.prakash.ambasta@gmail.com>
Updated•2 months ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2fc58e526510 Fix issues with non-unified builds missing header inclusions. r=emilio
Comment 9•2 months ago
|
||
| bugherder | ||
Description
•