breakage after "button to allow WPAD while using system proxy settings" (#621429)
Categories
(Core :: Networking: Proxy, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr115 | --- | unaffected |
| firefox124 | --- | unaffected |
| firefox125 | --- | wontfix |
| firefox126 | --- | fixed |
People
(Reporter: cmt, Assigned: cmt)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [necko-triaged])
Attachments
(2 files)
|
1.11 KB,
patch
|
Details | Diff | Splinter Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:125.0) Gecko/20100101 Firefox/125.0
Steps to reproduce:
In #62149 - https://hg.mozilla.org/releases/mozilla-release/rev/57b8feadc07203af4c975bd419bbfd7a537b921a#l8.58 - we call nsUnixSystemProxySettings::GetSystemWPADSetting() from toolkit/system/unixproxy/nsUnixSystemProxySettings.cpp , but that is not built when MOZ_ENABLE_LIBPROXY is set.
We have a report of breakage which can only be explained by this - see https://lists.freebsd.org/archives/dev-commits-ports-all/2024-April/109479.html
On a first hunch I'd suggest moving GetSystemWPADSetting() into common code, but maybe someone has a better idea - I'll have to try to much unraveling this will cause.
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Updated•2 months ago
|
Comment 1•2 months ago
|
||
:dotoole, since you are the author of the regressor, bug 621429, could you take a look? Also, could you set the severity field?
For more information, please visit BugBot documentation.
| Assignee | ||
Comment 2•2 months ago
|
||
After reviewing the relevant function, I decided that it was just too trivial to justify it's own file, so here's a patch which just copies it. Looks like that was all it took to fix the issue.
Comment 3•2 months ago
•
|
||
Thanks for investigating and writing the patch. Do you mind submitting it to phabricator, which is our current patch submitting pipeline?
Info on how to use phabricator: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
Thank you!
| Assignee | ||
Comment 5•2 months ago
|
||
In #621429 a call to nsUnixSystemProxySettings::GetSystemWPADSetting()
was added, but that function is not available for builds with
MOZ_ENABLE_LIBPROXY. The funtion is trivial enough to just
copy it across - else there'd more boilerplate than actual code.
| Assignee | ||
Comment 6•2 months ago
|
||
(In reply to Manuel Bucher [:manuel] from comment #3)
Thanks for investigating and writing the patch. Do you mind submitting it to phabricator, which is our current patch submitting pipeline?
Info on how to use phabricator: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
That maybe just happened.
Updated•2 months ago
|
Updated•2 months ago
|
Pushed by rjesup@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/15006906e885 GetSystemWPADSetting for libproxy-enabled builds r=jesup
Comment 8•2 months ago
|
||
Set release status flags based on info from the regressing bug 621429
Comment 9•2 months ago
|
||
| bugherder | ||
Comment 10•2 months ago
|
||
The patch landed in nightly and beta is affected.
:cmt, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox125towontfix.
For more information, please visit BugBot documentation.
| Assignee | ||
Comment 11•2 months ago
|
||
(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #10)
The patch landed in nightly and beta is affected.
:cmt, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox125towontfix.For more information, please visit BugBot documentation.
On the one hand I think this is not that important - affects only non-default build configuration (MOZ_ENABLE_LIBPROXY) - even if it carries about no specific risks. On the other hand it looks like I'm not allowed to set this "wontfix". You decide :)
Comment 12•2 months ago
|
||
I agree about backporting. People hitting this can cherry-pick the patch if needed.
Description
•