chore(github): update PR template. #21711
Conversation
0129f2d
to
3d0a28f
Compare
| @@ -1,15 +1,48 @@ | |||
| Thanks for opening a Pull Request (PR), here's a few guidelines as to what we need in your PR before we review it. | |||
There was a problem hiding this comment.
Per our discussion:
| Thanks for opening a Pull Request (PR), here's a few guidelines as to what we need in your PR before we review it. | |
| <!-- | |
| Thanks for opening a Pull Request (PR), here's a few guidelines as to what we need in your PR before we review it. | |
| --> |
There was a problem hiding this comment.
I tried making all the changes, as I understood them, in #21711 (Doesn't need merging, can be closed, it was just an easy way to edit the whole file)
There was a problem hiding this comment.
(Maybe I should have made the changes in suggestions like you did so the discussion was in one place 😬 )
There was a problem hiding this comment.
Your changes are large enough that I think it's a good idea to have them as a separate PR, even though it can be a bit confusing
There was a problem hiding this comment.
Left a summary comment on your PR @eviljeff let's align on what to do with it and then come back here to finish things off.
Co-authored-by: Mathieu Pillard <diox@users.noreply.github.com>
|
Note: we should consider adding "Fixes mozilla/addons#xxx" to the template to make transition to new unified new issue (which go to mozilla/addons) template |
Thanks for opening a Pull Request (PR), here's a few guidelines as to what we need in your PR before we review it.
Fixes: N/A
How did you solve the problem?
I updated the github PR template to include specific sections for required information and clear descriptions. Each section includes examples and links to help the PR author and specifies which sections are required.
What should the reviewer focus on?
If we want to maintain a separate pull request template for community PRs, that is also possible. We can create a directory of PR templates and open them with query parameters or selecting in the Web UI.
If we want to extend this template to other addon repositories, we could do so, but would require moving the addon repos to a separate org. Probably not worth it.
How to test this PR?
No testing required.