WorryFree Computers   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement All CircleCI tests in github actions #22250

Merged
merged 3 commits into from
May 31, 2024
Merged

Implement All CircleCI tests in github actions #22250

merged 3 commits into from
May 31, 2024

Conversation

KevinMind
Copy link
Contributor
@KevinMind KevinMind commented May 16, 2024 •
edited

Fixes: AMOENG-599

Description

This is the first PR in the final phase of the gha migration. It implements parity between circle ci and github actions for tests. All tests run in circle ci are also run in github actions.

Context

After merging this there are follow ups for finalizing the migration and for improving performance. Though we are at near parity with circle CI (while building the docker container so actually faster already).

This PR includes 2 sub PRs that could be merged before or with this one:

@KevinMind KevinMind marked this pull request as draft May 16, 2024 15:15
@KevinMind KevinMind force-pushed the migrate-all-of-the-things branch 9 times, most recently from 5f8181f to d35273f Compare May 17, 2024 14:46
@KevinMind KevinMind mentioned this pull request May 21, 2024
Merged
@KevinMind KevinMind force-pushed the migrate-all-of-the-things branch 19 times, most recently from a797b77 to 45ab1ac Compare May 22, 2024 08:52
@KevinMind KevinMind force-pushed the migrate-all-of-the-things branch 7 times, most recently from 9b3e0d3 to 3adfc0f Compare May 24, 2024 08:21
@KevinMind
Copy link
Contributor Author
KevinMind commented May 24, 2024 •
edited

Follow ups after this PR would be:

  • remove circle ci tests
  • reorganize test division for optimal performance
  • enable "auto" for core splitting in pytest
  • enable test splitting with pytest-split
  • rename the gha jobs more appropriately
  • clean up temporary and renamed runs in gha to clean up the actions view

Dependency related (can be inclusive or exclusive)

  • cache ./deps directory in ci runs to speed up installation
  • use "development" "production" targets to speed up installation
  • integrate installation of dev deps to startup process with "deps_container" in compose

@KevinMind KevinMind changed the title Migrate-all-of-the-things Implement All CircleCI tests in github actions May 24, 2024
@KevinMind KevinMind marked this pull request as ready for review May 24, 2024 08:38
@KevinMind KevinMind requested review from diox and wagnerand May 24, 2024 08:38
@KevinMind KevinMind force-pushed the migrate-all-of-the-things branch 2 times, most recently from af226e8 to 7369679 Compare May 24, 2024 12:01
@wagnerand
Copy link
Member

COMPOSE_FILE=docker-compose.yml:docker-compose.private.yml make up seems to work fine, thanks!

@KevinMind KevinMind force-pushed the migrate-all-of-the-things branch 6 times, most recently from 65d6e7f to 6fda92b Compare May 30, 2024 10:57
diox
diox approved these changes May 31, 2024
View reviewed changes
Copy link
Member
@diox diox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@willdurand
Copy link
Member

Fixes: AMOENG-599

Can we please reference GitHub issues here?

@KevinMind
Copy link
Contributor Author

@willdurand this is one of the issues without a github issue.

@KevinMind KevinMind merged commit ef033d0 into master May 31, 2024
22 checks passed
@KevinMind KevinMind deleted the migrate-all-of-the-things branch May 31, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diox diox diox approved these changes

@wagnerand wagnerand Awaiting requested review from wagnerand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@KevinMind @wagnerand @willdurand @diox