WorryFree Computers   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit GTMSessionFetcher version update to < 2.1.0 #10123

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Limit GTMSessionFetcher version update to < 2.1.0 #10123

merged 1 commit into from
Aug 22, 2022

Conversation

paulb777
Copy link
Member
@paulb777 paulb777 commented Aug 21, 2022 •
edited

Limit dependency GTMSessionFetcher version update to < 2.1.0 to avoid a new deprecation warning.

Fix #10055

GTMSessionFetcher deprecated an API used by FirebaseStorageInternal.

- WARN  | xcodebuild:  /Users/paulbeusterien/gh5/firebase-ios-sdk/FirebaseStorageInternal/Sources/FIRStorageTokenAuthorizer.h:35:50: warning: 'GTMFetcherAuthorizationProtocol' is deprecated: implement GTMSessionFetcherAuthorizer instead [-Wdeprecated-declarations]
- NOTE  | xcodebuild:  GTMSessionFetcher/Sources/Core/Public/GTMSessionFetcher/GTMSessionFetcher.h:644:1: note: 'GTMFetcherAuthorizationProtocol' has been explicitly marked deprecated here
- WARN  | xcodebuild:  /Users/paulbeusterien/gh5/firebase-ios-sdk/FirebaseStorageInternal/Sources/FIRStorageTokenAuthorizer.m:61:1: warning: implementing deprecated method [-Wdeprecated-implementations]
- NOTE  | xcodebuild:  GTMSessionFetcher/Sources/Core/Public/GTMSessionFetcher/GTMSessionFetcher.h:657:1: note: method 'authorizeRequest:delegate:didFinishSelector:' declared here

It would be a breaking change to update to the new 2.1.0 API.

I'm proposing to cherry-pick this to the 9.5 release branch

@charlotteliang charlotteliang self-requested a review August 22, 2022 18:25
@paulb777 paulb777 merged commit 35a7b07 into master Aug 22, 2022
@paulb777 paulb777 deleted the pb-limit-session-fetcher branch August 22, 2022 18:25
andrewheard pushed a commit that referenced this pull request Aug 22, 2022
@paulb777 @andrewheard
Limit dependency GTMSessionFetcher version update to < 2.1.0 to avoid…
c21ff20 
… a new deprecation warning (#10123)
andrewheard added a commit that referenced this pull request Aug 22, 2022
@andrewheard
Cherry-pick #10123 into Firebase 9.5.0
7f31a43
@paulb777 paulb777 mentioned this pull request Aug 23, 2022
Merged
charlotteliang pushed a commit that referenced this pull request Aug 31, 2022
@paulb777 @charlotteliang
Limit dependency GTMSessionFetcher version update to < 2.1.0 to avoid…
87c5789 
… a new deprecation warning (#10123)
@firebase firebase locked and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@charlotteliang charlotteliang charlotteliang approved these changes

Assignees
No one assigned
Labels
api: core api: storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly Testing Report
3 participants
@paulb777 @charlotteliang @google-oss-bot