Add core support with interop for Segmentation SDK. #3430
Conversation
…rs to be under sources folder.
Firebase/Core/FIRErrors.m
Outdated
| @@ -19,3 +19,4 @@ | |||
| NSString *const kFirebaseCoreErrorDomain = @"com.firebase.core"; | |||
| NSString *const kFirebasePerfErrorDomain = @"com.firebase.perf"; | |||
| NSString *const kFirebaseStorageErrorDomain = @"com.firebase.storage"; | |||
| NSString *const kFirebaseSegmentationErrorDomain = @"com.firebase.segmentation"; | |||
There was a problem hiding this comment.
Delete. FIRErrors is deprecated and nothing new should be added.
Firebase/Core/Private/FIRErrors.h
Outdated
| @@ -22,3 +22,4 @@ extern NSString *const kFirebaseErrorDomain; | |||
| extern NSString *const kFirebaseConfigErrorDomain; | |||
| extern NSString *const kFirebaseCoreErrorDomain; | |||
| extern NSString *const kFirebasePerfErrorDomain; | |||
| extern NSString *const kFirebaseSegmentationErrorDomain; | |||
| #import "FIRSegmentation.h" | ||
| #import "FirebaseSegmentation/Sources/Public/FIRSegmentation.h" | ||
|
|
||
| #import "FIRAppInternal.h" |
There was a problem hiding this comment.
Should be #import <FirebaseCore/FIRAppInternal.h> for this and other Core Private headers.
| @@ -0,0 +1,86 @@ | |||
| #import "FIRSegmentationComponent.h" | |||
|
|
|||
| #import "FIRAppInternal.h" | |||
There was a problem hiding this comment.
Use module import format here too.
|
|
||
| @end | ||
|
|
||
| /// A concrete implementation for FIRSegmentationInterop to create Segmentation instances and |
There was a problem hiding this comment.
Is there a need for FIRSegmentationInterop?
There was a problem hiding this comment.
Is there a reason not to? What is the alternative? I thought all products were moving to using interop.
There was a problem hiding this comment.
Interop is only needed for products that want to manage their interface to other Firebase dependencies separately from their library implementation. Will Segmentation have Firebase pod dependencies?
There was a problem hiding this comment.
Yes, Segmentation will need to depend on IID and FIS.
FirebaseSegmentation.podspec
Outdated
| @@ -21,7 +21,7 @@ Firebase Segmentation enables you to associate your custom application instance | |||
| s.prefix_header_file = false | |||
|
|
|||
| s.source_files = 'FirebaseSegmentation/Sources/**/*' | |||
| s.public_header_files = 'FirebaseSegmentation/Public/*.h' | |||
| s.public_header_files = 'FirebaseSegmentation/Sources/Public/*.h' | |||
|
|
|||
| s.dependency 'FirebaseCore', '~> 6.0' | |||
|
|
||
| @end | ||
|
|
||
| /// A concrete implementation for FIRSegmentationInterop to create Segmentation instances and |
There was a problem hiding this comment.
Interop is only needed for products that want to manage their interface to other Firebase dependencies separately from their library implementation. Will Segmentation have Firebase pod dependencies?
|
Please fix the travis failure before merging. |
|
Yes, segmentation will have IID and FIS as pod dependencies. |
Add core support with interop for Segmentation SDK. Also update header file location to within sources folder.