-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement unified emulator settings API proposal #5916
Conversation
92bad75
to
2797294
Compare
859e9c8
to
740d830
Compare
@morganchen12 FWIW storage is not in scope, there's no Storage emulator. |
da086ac
to
f8628d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, deferring iCore approval to @ryanwilson for API change approval
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firestore LGTM
Functions/FirebaseFunctions/Public/FirebaseFunctions/FIRFunctions.h
Outdated
Show resolved
Hide resolved
Functions/FirebaseFunctions/Public/FirebaseFunctions/FIRFunctions.h
Outdated
Show resolved
Hide resolved
e4ece34
to
583d704
Compare
Quickstart test will be fixed by firebase/quickstart-ios#1075. @schmidt-sebastian, do you know why the integration test is failing? |
Could be more issues related to the GHA Xcode 12 transition. We should get the full summary from tonight's cron run. |
@paulb777 do you know why the quickstart test is failing with
when ABTesting isn't in the list of dependencies? I wasn't able to reproduce the failure locally. |
@morganchen12 It's a result of this script that makes sure that all Firebase dependency pods are sourced from the repo. |
The API proposal in question is "Unified Emulator Connection Settings".
Googlers see b/158072394