WorryFree Computers   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuthProvider with tenant support #7990

Closed
Busta117 opened this issue Apr 28, 2021 · 4 comments · Fixed by #9100
Closed

OAuthProvider with tenant support #7990

Busta117 opened this issue Apr 28, 2021 · 4 comments · Fixed by #9100

Comments

@Busta117
Copy link

[REQUIRED] Step 1: Describe your environment

  • Xcode version: 12.4
  • Firebase SDK version: 7.10.0
  • Installation method: CocoaPods
  • Firebase Component: Auth

[REQUIRED] Step 2: Describe the problem

Steps to reproduce:

there is a problem when we try to signin with a specific tenant and specific provider using OAuthProvider(see code below for a better understand)

in the file FIROAuthProvider.m line 311 where the params are added in the URL, the param tid is missed, and in some cases this param is needed to the correct functionality of the authentication, don't know if it's missed in the other providers, but in this case of the oauth provider is needed with a multi tenant implementation.

something to add is that Android SDK create the url in a right way when we use the tenant id in the same way.

Relevant Code:

let's use this code to perform the signin...

let auth = Auth.auth()
auth.tenantID = "tenant_id"
let provider = OAuthProvider(providerID: "provider_id", auth: auth)

auth.signIn(with: provider, uiDelegate: nil) { authResult, error in
// handle here the result
}
@rizafran
Copy link
Contributor
rizafran commented May 3, 2021

Hi @Busta117, may I know if you're getting any error when signing in? Can you also share the expected vs actual behavior of your use case? Thanks.

@google-oss-bot
Copy link

Hey @Busta117. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

@Busta117
Copy link
Author

hi @rizafran

there is no error at login, cuz login is never presented, this is the error when i try to load the webview of the login

Error Domain=FIRAuthErrorDomain Code=17063 "The app verification process has failed, print and inspect the error details for more information" UserInfo={FIRAuthErrorUserInfoNameKey=ERROR_WEB_USER_INTERACTION_FAILURE, NSLocalizedFailureReason=[auth/operation-not-allowed] - The identity provider configuration is not found., NSLocalizedDescription=The app verification process has failed, print and inspect the error details for more information}

and as i said, adding that tid param login webview is loaded normally, but sdk don't add that param

@weixifan
Copy link

Thank you for the information. I've filed an internal issue b/188421113 to track.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants