WorryFree Computers   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Links shouldn't read from defaultOptions #2112

Closed
ryanwilson opened this issue Nov 22, 2018 · 5 comments
Closed

Dynamic Links shouldn't read from defaultOptions #2112

ryanwilson opened this issue Nov 22, 2018 · 5 comments
Assignees
@dmandar
Labels
api: dynamiclinks
Milestone
5.14.0

Comments

@ryanwilson
Copy link
Member

firebase-ios-sdk/Firebase/DynamicLinks/FDLURLComponents/FIRDynamicLinkComponentsKeyProvider.m

Line 29 in c724f9d

apiKey = [FIROptions defaultOptions].APIKey;

Currently Dynamic Links reads from the defaultOptions plist to get the API key - this should be fetched from FIRApp incase developers manually set options.

This was discovered by @forsen in #230.
@forsen forsen mentioned this issue Nov 23, 2018
Closed
30 tasks
@doddyth
Copy link
doddyth commented Nov 27, 2018

Any update for this issue? Right now, we're stuck. Any help will be appreciated. Thank you.

@ryanwilson
Copy link
Member Author

I'll try to take a look today to see how invasive the change will be - hopefully it's easy to pipe through.

@ryanwilson ryanwilson mentioned this issue Nov 27, 2018
Merged
@ryanwilson
Copy link
Member Author

This was fixed and will be out in the next release.

@paulb777 paulb777 added this to the M39 milestone Nov 28, 2018
@paulb777 paulb777 mentioned this issue Nov 28, 2018
Merged
@doddyth
Copy link
doddyth commented Nov 30, 2018

Wow, thank you for the fast fixed! May I know when 5.14 release come out?

@ryanwilson
Copy link
Member Author

You're very welcome 😄 by policy, we don't commit to dates for upcoming releases, but I will say that we are hoping to get 5.14.0 out with this issue fixed next week.

@thisisthekap thisisthekap mentioned this issue Sep 12, 2019
Closed
@firebase firebase locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmandar dmandar

Labels
api: dynamiclinks
Projects
None yet
Milestone
5.14.0
Development

No branches or pull requests
4 participants
@paulb777 @ryanwilson @doddyth @dmandar