WorryFree Computers   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StorageReference.putFile completion never called (if file errors) #2350

Closed
simonbengtsson opened this issue Feb 5, 2019 · 7 comments
Closed

StorageReference.putFile completion never called (if file errors) #2350

simonbengtsson opened this issue Feb 5, 2019 · 7 comments
Assignees
@maksymmalyhin
Labels
api: storage

Comments

@simonbengtsson
Copy link
simonbengtsson commented Feb 5, 2019 •
edited
  • Xcode version: 10.1
  • Firebase SDK version: 5.16
  • Firebase Component: Storage
  • Component version: 3.1.0

When using StorageReference.putFile errors such as "no such file" gets silenced and the completion block is never called.

Relevant Code/Steps to reproduce

let localFile = URL(string: "non/existing/file/url")!
let ref = Storage.storage().reference(withPath: "folder/file")
ref.putFile(from: localFile, metadata: nil) { metadata, error in
    print("I would expect this to be called with an error but it never does")
}

At first glance it seems like #1888 is related, but there it seemed like people had troubles uploading existing files as well.
@simonbengtsson simonbengtsson changed the title StorageReference.putFile completion never called (when file errors) StorageReference.putFile completion never called (if file errors) Feb 5, 2019
@maksymmalyhin maksymmalyhin self-assigned this Feb 27, 2019
maksymmalyhin added a commit that referenced this issue Feb 27, 2019
@maksymmalyhin
FIRStorageUploadTask: validate data and fileURL before upload (#2350)
bd55a09
maksymmalyhin added a commit that referenced this issue Feb 27, 2019
@maksymmalyhin
FIRStorageReferenceTests: Verify a specific error (#2350)
ef986b9
maksymmalyhin added a commit that referenced this issue Feb 28, 2019
@maksymmalyhin
FIRStorageReference: error message, test fix (#2350)
92bca47
This was referenced Feb 28, 2019
Merged
Closed
@maksymmalyhin
Copy link
Contributor

Note: The same issue happens when the file ULR points to an empty file.

@maksymmalyhin
Copy link
Contributor

BTW, I am not sure if uploading an empty file makes sense here... @ryanwilson @schmidt-sebastian, Do you think it does?

It looks like we can throw a validation error in case of the empty file as well, then the issue can be closed by a single PR in the Firebase repo, so GTMSessionUploadFetcher can be fixed later.

maksymmalyhin added a commit that referenced this issue Feb 28, 2019
@maksymmalyhin
#2350: Punctuation
5009de3
maksymmalyhin added a commit that referenced this issue Feb 28, 2019
@maksymmalyhin
FIRStorageReferenceTests: naming (#2350)
6a731ae
@maksymmalyhin maksymmalyhin mentioned this issue Feb 28, 2019
Closed
maksymmalyhin added a commit that referenced this issue Feb 28, 2019
@maksymmalyhin
Tests fixed (#2350)
3dbf22c
maksymmalyhin added a commit that referenced this issue Feb 28, 2019
@maksymmalyhin
FIRStorageReferenceTests fixed for Mac OS (#2350)
1155787
@schmidt-sebastian
Copy link
Contributor

I don't think we should reject empty files. After all, this API is going to be user with user-provided files and we should handle all file sizes gracefully for our developers. Supporting empty files is certainly not a high priority but we should support it in the long term.

maksymmalyhin added a commit that referenced this issue Mar 3, 2019
@maksymmalyhin
FIRStorageUploadTask: validate content just before uploading (#2350)
d376ee1
schmidt-sebastian pushed a commit that referenced this issue Mar 4, 2019
@maksymmalyhin @schmidt-sebastian
FIRStorageUploadTask: fail on invalid file URL (#2458)
4dfebfc 
* FIRStorageUploadTask: validate data and fileURL before upload (#2350)

* FIRStorageReferenceTests: Verify a specific error (#2350)

* Code cleanup. More informative error.

* FIRStorageReference: error message, test fix (#2350)

* Run ./scripts/style.sh

* #2350: Punctuation

* FIRStorageReferenceTests: naming (#2350)

* Run ./scripts/style.sh

* Tests fixed (#2350)

* FIRStorageReferenceTests fixed for Mac OS (#2350)

* FIRStorageUploadTask: validate content just before uploading (#2350)
@Black-riddle
Copy link

Is anyone facing the same problem even when the file is not empty (an image in my case)
PS: I am
Using Firebase (5.14.0)
Using FirebaseAuth (5.2.0)
Using FirebaseAuthInterop (1.0.0)
Using FirebaseCore (5.1.9)
Using FirebaseStorage (3.0.3)

@maksymmalyhin
Copy link
Contributor

@Black-riddle your Firebase looks a bit old. Would it be possible to test your issue with Firebase
5.19.0?

@Black-riddle
Copy link

@maksymmalyhin Thank you now it works :)

@morganchen12 morganchen12 removed their assignment Jun 20, 2019
@maksymmalyhin
Copy link
Contributor

The issue should be completely fixed by the fix of google/gtm-session-fetcher#140

@firebase firebase locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maksymmalyhin maksymmalyhin

Labels
api: storage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@maksymmalyhin @simonbengtsson @morganchen12 @schmidt-sebastian @Black-riddle @google-oss-bot