Simon Montagu :smontagu Assignee
	Description • 11 years ago

See bug 854041 comment 12:

> I emailed Mark Davis. On Simplified vs. Traditional, he said:
> 
> "The test can only be applied if the characters are meant to be chinese.​ So
> "写真だけの結婚式​" is Japanese, and shouldn't be tested."
> 
> I asked if there was a programmatic way of telling, with only access to the
> label. He said:
> 
> "Not unless the domain is restricted to only allow Chinese names. I think,
> for example, that .CN doesn't allow arbitrary CJK characters, just the ones
> in Chinese."
> 
> He also said:
> 
> "B. The test for S vs T needs to be not whether the character has a T or S
> variant​, but whether the character is an S or T variant. In any event, we
> need to be much clearer in that section exactly how to use Unihan."
> 
> -- So I think we should remove the S vs T test for now, until it's more
> clear exactly what, if anything, we can do.

	Gervase Markham [:gerv]
	Comment 2 • 11 years ago

I would remove the code entirely. That's what source control is for :-)

Gerv

	Honza Bambas (:mayhemer)
	Comment 3 • 11 years ago

Comment on attachment 732850 [details] [diff] [review]
Patch

Review of attachment 732850 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for delay.

r=honzab

	Simon Montagu :smontagu Assignee
	Comment 4 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/2089d4146c21

	Ryan VanderMeulen [:RyanVM]
	Comment 5 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/2089d4146c21

	Matt Wobensmith [:mwobensmith][:matt:]
	Comment 6 • 11 years ago

Confirmed fixed, m-c, 2013-04-15.

I compared against the output of m-c 2013-03-22 and we no longer block this case. See bug 854041 for more details.