WorryFree Computers   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only attempt to flush reports for start up crashes #4786

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Only attempt to flush reports for start up crashes #4786

merged 1 commit into from
Mar 15, 2023

Conversation

mrober
Copy link
Contributor
@mrober mrober commented Mar 15, 2023

This will avoid blocking the main thread for regular crashes, and help avoid ANRs.

No change log: This is part of "* [changed] Improved crash reporting reliability for crashes that occur early in the app's
lifecycle."

@mrober mrober requested a review from themiswang March 15, 2023 15:08
@github-actions
Copy link
Contributor
github-actions bot commented Mar 15, 2023 •
edited

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@mrober mrober enabled auto-merge (squash) March 15, 2023 15:10
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-crashlytics

    Overall coverage changed from 10.13% (6d645d0) to 10.12% (d74cfd7) by -0.01%.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ItuZwVx3PM.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-crashlytics

    TypeBase (6d645d0)Merge (d74cfd7)Diff
    aar350 kB350 kB+172 B (+0.0%)
    apk (aggressive)246 kB246 kB+44 B (+0.0%)
    apk (release)1.48 MB1.48 MB-60 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0TTUVa9ZvU.html

@mrober mrober merged commit 6154d89 into master Mar 15, 2023
@mrober mrober deleted the crashlytics-startup branch March 15, 2023 15:25
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-cls

    DeviceStatisticsDistributions
    oriole-32
    Percentile6d645d0d74cfd7DiffSignificant (?)
    p109.45 ±1 ms11.3 ±5 ms+1.89 ms (+20.0%)NO
    p2510.0 ±1 ms12.2 ±5 ms+2.17 ms (+21.7%)NO
    p5011.0 ±1 ms13.6 ±6 ms+2.66 ms (+24.2%)NO
    p7512.1 ±1 ms15.4 ±7 ms+3.24 ms (+26.7%)NO
    p9013.7 ±2 ms17.2 ±8 ms+3.53 ms (+25.8%)NO

    20 test runs in comparison
    CommitTest Runs
    6d645d0
    • 2023-03-15_05:04:31.942017_vaVj
    • 2023-03-15_05:04:31.948865_wyIs
    • 2023-03-15_05:04:31.950089_eeEP
    • 2023-03-15_05:04:31.950106_pSdX
    • 2023-03-15_05:04:31.950114_ccMY
    • 2023-03-15_05:04:31.950120_fqfI
    • 2023-03-15_05:04:31.950127_iqJP
    • 2023-03-15_05:04:31.950133_sYxa
    • 2023-03-15_05:04:31.950139_lBgD
    • 2023-03-15_05:04:31.950145_yMvo
    d74cfd7
    • 2023-03-15_15:24:27.270631_QJlD
    • 2023-03-15_15:24:27.271408_sIeY
    • 2023-03-15_15:24:27.271418_rVsW
    • 2023-03-15_15:24:27.271427_cxIx
    • 2023-03-15_15:24:27.271433_ievS
    • 2023-03-15_15:24:27.271438_ymxr
    • 2023-03-15_15:24:27.271444_fUcn
    • 2023-03-15_15:24:27.271449_kdUp
    • 2023-03-15_15:24:27.271455_NIcQ
    • 2023-03-15_15:24:27.271460_TJvi
    redfin-30
    Percentile6d645d0d74cfd7DiffSignificant (?)
    p1014.2 ±7 ms14.6 ±6 ms+368 μs (+2.6%)NO
    p2514.9 ±7 ms15.7 ±6 ms+755 μs (+5.1%)NO
    p5016.1 ±8 ms17.4 ±7 ms+1.38 ms (+8.6%)NO
    p7517.7 ±9 ms19.9 ±8 ms+2.15 ms (+12.1%)NO
    p9019.9 ±9.5 ms22.8 ±9 ms+2.95 ms (+14.9%)NO

    20 test runs in comparison
    CommitTest Runs
    6d645d0
    • 2023-03-15_05:04:31.942017_vaVj
    • 2023-03-15_05:04:31.948865_wyIs
    • 2023-03-15_05:04:31.950089_eeEP
    • 2023-03-15_05:04:31.950106_pSdX
    • 2023-03-15_05:04:31.950114_ccMY
    • 2023-03-15_05:04:31.950120_fqfI
    • 2023-03-15_05:04:31.950127_iqJP
    • 2023-03-15_05:04:31.950133_sYxa
    • 2023-03-15_05:04:31.950139_lBgD
    • 2023-03-15_05:04:31.950145_yMvo
    d74cfd7
    • 2023-03-15_15:24:27.270631_QJlD
    • 2023-03-15_15:24:27.271408_sIeY
    • 2023-03-15_15:24:27.271418_rVsW
    • 2023-03-15_15:24:27.271427_cxIx
    • 2023-03-15_15:24:27.271433_ievS
    • 2023-03-15_15:24:27.271438_ymxr
    • 2023-03-15_15:24:27.271444_fUcn
    • 2023-03-15_15:24:27.271449_kdUp
    • 2023-03-15_15:24:27.271455_NIcQ
    • 2023-03-15_15:24:27.271460_TJvi

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile6d645d0d74cfd7DiffSignificant (?)
    p10192 ±6 ms204 ±17 ms+11.2 ms (+5.8%)NO
    p25199 ±7 ms211 ±19 ms+12.0 ms (+6.0%)NO
    p50207 ±8 ms221 ±26 ms+14.3 ms (+6.9%)NO
    p75215 ±9 ms236 ±33 ms+20.4 ms (+9.5%)NO
    p90224 ±10 ms251 ±37 ms+27.0 ms (+12.1%)NO

    20 test runs in comparison
    CommitTest Runs
    6d645d0
    • 2023-03-15_05:04:31.942017_vaVj
    • 2023-03-15_05:04:31.948865_wyIs
    • 2023-03-15_05:04:31.950089_eeEP
    • 2023-03-15_05:04:31.950106_pSdX
    • 2023-03-15_05:04:31.950114_ccMY
    • 2023-03-15_05:04:31.950120_fqfI
    • 2023-03-15_05:04:31.950127_iqJP
    • 2023-03-15_05:04:31.950133_sYxa
    • 2023-03-15_05:04:31.950139_lBgD
    • 2023-03-15_05:04:31.950145_yMvo
    d74cfd7
    • 2023-03-15_15:24:27.270631_QJlD
    • 2023-03-15_15:24:27.271408_sIeY
    • 2023-03-15_15:24:27.271418_rVsW
    • 2023-03-15_15:24:27.271427_cxIx
    • 2023-03-15_15:24:27.271433_ievS
    • 2023-03-15_15:24:27.271438_ymxr
    • 2023-03-15_15:24:27.271444_fUcn
    • 2023-03-15_15:24:27.271449_kdUp
    • 2023-03-15_15:24:27.271455_NIcQ
    • 2023-03-15_15:24:27.271460_TJvi
    redfin-30
    Percentile6d645d0d74cfd7DiffSignificant (?)
    p10232 ±4 ms253 ±5 ms+21.8 ms (+9.4%)YES
    p25237 ±5 ms260 ±5 ms+22.2 ms (+9.3%)MAYBE
    p50244 ±6 ms267 ±5 ms+23.1 ms (+9.4%)MAYBE
    p75253 ±7 ms277 ±6 ms+24.3 ms (+9.6%)MAYBE
    p90263 ±6 ms291 ±8 ms+28.1 ms (+10.7%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    6d645d0
    • 2023-03-15_05:04:31.942017_vaVj
    • 2023-03-15_05:04:31.948865_wyIs
    • 2023-03-15_05:04:31.950089_eeEP
    • 2023-03-15_05:04:31.950106_pSdX
    • 2023-03-15_05:04:31.950114_ccMY
    • 2023-03-15_05:04:31.950120_fqfI
    • 2023-03-15_05:04:31.950127_iqJP
    • 2023-03-15_05:04:31.950133_sYxa
    • 2023-03-15_05:04:31.950139_lBgD
    • 2023-03-15_05:04:31.950145_yMvo
    d74cfd7
    • 2023-03-15_15:24:27.270631_QJlD
    • 2023-03-15_15:24:27.271408_sIeY
    • 2023-03-15_15:24:27.271418_rVsW
    • 2023-03-15_15:24:27.271427_cxIx
    • 2023-03-15_15:24:27.271433_ievS
    • 2023-03-15_15:24:27.271438_ymxr
    • 2023-03-15_15:24:27.271444_fUcn
    • 2023-03-15_15:24:27.271449_kdUp
    • 2023-03-15_15:24:27.271455_NIcQ
    • 2023-03-15_15:24:27.271460_TJvi

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2t6WeqaZAE/index.html

@firebase firebase locked and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@themiswang themiswang themiswang approved these changes

Assignees
No one assigned
Labels
main-merge-ack no-changelog size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrober @google-oss-bot @themiswang