WorryFree Computers   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the logic to generate .pro file #664

Merged
merged 4 commits into from
Sep 15, 2021
Merged

Fix the logic to generate .pro file #664

merged 4 commits into from
Sep 15, 2021

Conversation

cynthiajoan
Copy link
Contributor
@cynthiajoan cynthiajoan commented Sep 15, 2021 •
edited

To address issue #604

@google-cla google-cla bot added the cla: yes label Sep 15, 2021
DellaBitta
DellaBitta requested changes Sep 15, 2021
View reviewed changes
Copy link
Contributor
@DellaBitta DellaBitta left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes should be under 8.5.0.

You should merge main into your branch first to see the 8.5.0 release notes header in your branch.

@cynthiajoan
Copy link
Contributor Author

Can you update the release notes please?

Updated

@cynthiajoan cynthiajoan added the tests-requested: quick Trigger a quick set of integration tests. label Sep 15, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Sep 15, 2021
@github-actions
Copy link
github-actions bot commented Sep 15, 2021 •
edited

❌  Integration test FAILED

Requested by @DellaBitta on commit 2008044
Last updated: Wed Sep 15 15:41 PDT 2021
View integration test log & download artifacts

Failures Configs
messaging [TEST] [ERROR] [Android] [All os] [android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Sep 15, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 15, 2021
@DellaBitta DellaBitta merged commit 2008044 into main Sep 15, 2021
@DellaBitta DellaBitta deleted the feature/rc_rest_update branch September 15, 2021 20:22
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Sep 15, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 15, 2021
@firebase firebase locked and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

@a-maurice a-maurice a-maurice approved these changes

Assignees
No one assigned
Labels
cla: yes tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cynthiajoan @DellaBitta @a-maurice