Remove peer deps from auth-interop-types #6940

hsubox76 · 2023-01-10T18:17:26Z

auth-interop-types doesn't have any dependencies or imports and it's likely the peerDependencies only appears in its package.json because of a copy-paste mistake when the package was created.

Likely causing warnings as described in firebase-admin: firebase/firebase-admin-node#973

changeset-bot · 2023-01-10T18:17:29Z

🦋 Changeset detected

Latest commit: d16a5a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@firebase/auth-interop-types	Patch
@firebase/database	Patch
@firebase/functions	Patch
@firebase/database-compat	Patch
firebase	Patch
@firebase/functions-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2023-01-10T18:56:32Z

Size Report ¹

Affected Products

@firebase/database
Type Base (50b8191) Merge (f3a0f6c) Diff
browser 247 kB 247 kB +2 B (+0.0%)
esm5 276 kB 276 kB +2 B (+0.0%)
main 281 kB 281 kB +2 B (+0.0%)
module 247 kB 247 kB +2 B (+0.0%)
@firebase/database-compat/standalone
Type Base (50b8191) Merge (f3a0f6c) Diff
main 370 kB 370 kB +2 B (+0.0%)

`bundle`

Type	Base (`50b8191`)	Merge (`f3a0f6c`)	Diff
database (Append to a list of data)	148 kB	148 kB	+2 B (+0.0%)
database (Filtering data)	147 kB	147 kB	+2 B (+0.0%)
database (Listen for child events)	163 kB	163 kB	+2 B (+0.0%)
database (Listen for value events + Detach listeners)	163 kB	163 kB	+2 B (+0.0%)
database (Listen for value events)	163 kB	163 kB	+2 B (+0.0%)
database (Read data once)	163 kB	163 kB	+2 B (+0.0%)
database (Save data as transactions)	165 kB	165 kB	+2 B (+0.0%)
database (Sort data)	148 kB	148 kB	+2 B (+0.0%)
database (Write data)	147 kB	147 kB	+2 B (+0.0%)

firebase
Type Base (50b8191) Merge (f3a0f6c) Diff
firebase-compat.js 746 kB 746 kB +2 B (+0.0%)
firebase-database-compat.js 165 kB 165 kB +2 B (+0.0%)
firebase-database.js 154 kB 154 kB +2 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/CnWmWZwOck.html

google-oss-bot · 2023-01-10T19:18:28Z

Size Analysis Report ¹

Affected Products

@firebase/database
- DataSnapshot
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 117 kB 117 kB +2 B (+0.0%)
  size-with-ext-deps 138 kB 138 kB +2 B (+0.0%)
- Database
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 115 kB 115 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- OnDisconnect
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 119 kB 119 kB +2 B (+0.0%)
  size-with-ext-deps 141 kB 141 kB +2 B (+0.0%)
- QueryConstraint
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- TransactionResult
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- _QueryImpl
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 115 kB 115 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- _QueryParams
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 115 kB 115 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- _ReferenceImpl
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 115 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- _TEST_ACCESS_forceRestClient
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- _TEST_ACCESS_hijackHash
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- _repoManagerDatabaseFromApp
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- _setSDKVersion
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 115 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- _validatePathString
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- _validateWritablePath
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- child
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- connectDatabaseEmulator
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 138 kB 138 kB +2 B (+0.0%)
- enableLogging
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- endAt
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 118 kB 118 kB +2 B (+0.0%)
  size-with-ext-deps 139 kB 139 kB +2 B (+0.0%)
- endBefore
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 118 kB 118 kB +2 B (+0.0%)
  size-with-ext-deps 139 kB 139 kB +2 B (+0.0%)
- equalTo
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 119 kB 119 kB +2 B (+0.0%)
  size-with-ext-deps 140 kB 140 kB +2 B (+0.0%)
- forceLongPolling
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- forceWebSockets
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- get
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 132 kB 132 kB +2 B (+0.0%)
  size-with-ext-deps 154 kB 154 kB +2 B (+0.0%)
- getDatabase
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 117 kB 117 kB +2 B (+0.0%)
  size-with-ext-deps 146 kB 146 kB +2 B (+0.0%)
- goOffline
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- goOnline
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- increment
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- limitToFirst
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- limitToLast
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- off
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 124 kB 124 kB +2 B (+0.0%)
  size-with-ext-deps 145 kB 145 kB +2 B (+0.0%)
- onChildAdded
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 133 kB 133 kB +2 B (+0.0%)
  size-with-ext-deps 154 kB 154 kB +2 B (+0.0%)
- onChildChanged
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 133 kB 133 kB +2 B (+0.0%)
  size-with-ext-deps 154 kB 154 kB +2 B (+0.0%)
- onChildMoved
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 133 kB 133 kB +2 B (+0.0%)
  size-with-ext-deps 154 kB 154 kB +2 B (+0.0%)
- onChildRemoved
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 133 kB 133 kB +2 B (+0.0%)
  size-with-ext-deps 154 kB 154 kB +2 B (+0.0%)
- onDisconnect
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 120 kB 120 kB +2 B (+0.0%)
  size-with-ext-deps 141 kB 141 kB +2 B (+0.0%)
- onValue
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 133 kB 133 kB +2 B (+0.0%)
  size-with-ext-deps 154 kB 154 kB +2 B (+0.0%)
- orderByChild
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 118 kB 118 kB +2 B (+0.0%)
  size-with-ext-deps 139 kB 139 kB +2 B (+0.0%)
- orderByKey
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 117 kB 117 kB +2 B (+0.0%)
  size-with-ext-deps 138 kB 138 kB +2 B (+0.0%)
- orderByPriority
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 117 kB 117 kB +2 B (+0.0%)
  size-with-ext-deps 138 kB 138 kB +2 B (+0.0%)
- orderByValue
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 117 kB 117 kB +2 B (+0.0%)
  size-with-ext-deps 138 kB 138 kB +2 B (+0.0%)
- push
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 118 kB 118 kB +2 B (+0.0%)
  size-with-ext-deps 139 kB 139 kB +2 B (+0.0%)
- query
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- ref
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- refFromURL
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 138 kB 138 kB +2 B (+0.0%)
- remove
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 138 kB 138 kB +2 B (+0.0%)
- runTransaction
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 135 kB 135 kB +2 B (+0.0%)
  size-with-ext-deps 156 kB 156 kB +2 B (+0.0%)
- serverTimestamp
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 137 kB 137 kB +2 B (+0.0%)
- set
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 116 kB 116 kB +2 B (+0.0%)
  size-with-ext-deps 138 kB 138 kB +2 B (+0.0%)
- setPriority
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 117 kB 117 kB +2 B (+0.0%)
  size-with-ext-deps 138 kB 138 kB +2 B (+0.0%)
- setWithPriority
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 117 kB 117 kB +2 B (+0.0%)
  size-with-ext-deps 138 kB 138 kB +2 B (+0.0%)
- startAfter
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 118 kB 118 kB +2 B (+0.0%)
  size-with-ext-deps 139 kB 139 kB +2 B (+0.0%)
- startAt
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 118 kB 118 kB +2 B (+0.0%)
  size-with-ext-deps 139 kB 139 kB +2 B (+0.0%)
- update
  Size
  Type Base (50b8191) Merge (f3a0f6c) Diff
  size 118 kB 118 kB +2 B (+0.0%)
  size-with-ext-deps 139 kB 139 kB +2 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/r4CrwBvWH7.html

dwyfrequency

LGTM

remove peer deps from auth-interop-types

fdd7e2e

add changeset

d16a5a0

hsubox76 marked this pull request as ready for review January 11, 2023 23:26

hsubox76 requested review from egilmorez, avolkovi, lisajian, sam-gc and yuchenshi as code owners January 11, 2023 23:26

lisajian approved these changes Jan 11, 2023

View reviewed changes

hsubox76 mentioned this pull request Jan 12, 2023

Meet peer dependency of @firebase/auth-interop-types #4087

Closed

dwyfrequency approved these changes Jan 13, 2023

View reviewed changes

hsubox76 merged commit e9bcd4c into master Jan 13, 2023

hsubox76 deleted the ch-fix-auth-interop branch January 13, 2023 19:18

google-oss-bot mentioned this pull request Jan 17, 2023

Version Packages #6953

Merged

firebase locked and limited conversation to collaborators Feb 13, 2023

Remove peer deps from auth-interop-types #6940

Remove peer deps from auth-interop-types #6940

Conversation

🦋 Changeset detected

Size Report 1

Affected Products

@firebase/database

@firebase/database-compat/standalone

bundle

firebase

Test Logs

Size Analysis Report 1

Affected Products

@firebase/database

DataSnapshot

Database

OnDisconnect

QueryConstraint

TransactionResult

_QueryImpl

_QueryParams

_ReferenceImpl

_TEST_ACCESS_forceRestClient

_TEST_ACCESS_hijackHash

_repoManagerDatabaseFromApp

_setSDKVersion

_validatePathString

_validateWritablePath

child

connectDatabaseEmulator

enableLogging

endAt

endBefore

equalTo

forceLongPolling

forceWebSockets

get

getDatabase

goOffline

goOnline

increment

limitToFirst

limitToLast

off

onChildAdded

onChildChanged

onChildMoved

onChildRemoved

onDisconnect

onValue

orderByChild

orderByKey

orderByPriority

orderByValue

push

query

ref

refFromURL

remove

runTransaction

serverTimestamp

set

setPriority

setWithPriority

startAfter

startAt

update

Test Logs

Choose a reason for hiding this comment

Size Report ¹

`@firebase/database`

`@firebase/database-compat/standalone`

`bundle`

`firebase`

Size Analysis Report ¹

`@firebase/database`

`DataSnapshot`

`Database`

`OnDisconnect`

`QueryConstraint`

`TransactionResult`

`_QueryImpl`

`_QueryParams`

`_ReferenceImpl`

`_TEST_ACCESS_forceRestClient`

`_TEST_ACCESS_hijackHash`

`_repoManagerDatabaseFromApp`

`_setSDKVersion`

`_validatePathString`

`_validateWritablePath`

`child`

`connectDatabaseEmulator`

`enableLogging`

`endAt`

`endBefore`

`equalTo`

`forceLongPolling`

`forceWebSockets`

`get`

`getDatabase`

`goOffline`

`goOnline`

`increment`

`limitToFirst`

`limitToLast`

`off`

`onChildAdded`

`onChildChanged`

`onChildMoved`

`onChildRemoved`

`onDisconnect`

`onValue`

`orderByChild`

`orderByKey`

`orderByPriority`

`orderByValue`

`push`

`query`

`ref`

`refFromURL`

`remove`

`runTransaction`

`serverTimestamp`

`set`

`setPriority`

`setWithPriority`

`startAfter`

`startAt`

`update`