Change _fail to use AuthErrorCode.INTERNAL_ERROR and pass in error me… #7038

NhienLam · 2023-02-14T23:36:17Z

Currently, auth/network-request-failed is caused by many different issues. After this change, if someone sees a auth/network-request-failed error, then it means the API call timed out (

firebase-js-sdk/packages/auth/src/api/index.ts

Line 141 in 04dcdbb

networkTimeout.promise

and

firebase-js-sdk/packages/auth/src/api/index.ts

Line 234 in 04dcdbb

_createError(this.auth, AuthErrorCode.NETWORK_REQUEST_FAILED)

).

Other failures will be thrown with AuthErrorCode.INTERNAL_ERROR and an error message.

…sssage

changeset-bot · 2023-02-14T23:36:20Z

🦋 Changeset detected

Latest commit: 19b78a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/auth	Patch
@firebase/auth-compat	Patch
firebase	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2023-02-15T00:02:21Z

Size Report ¹

Affected Products

`@firebase/auth`

Type	Base (`b5a1a60`)	Merge (`8a4c7b0`)	Diff
browser	156 kB	156 kB	+12 B (+0.0%)
cordova	184 kB	184 kB	+14 B (+0.0%)
esm5	205 kB	205 kB	+14 B (+0.0%)
main	148 kB	148 kB	+14 B (+0.0%)
module	156 kB	156 kB	+12 B (+0.0%)
react-native	168 kB	168 kB	+14 B (+0.0%)

@firebase/auth/cordova
Type Base (b5a1a60) Merge (8a4c7b0) Diff
browser 184 kB 184 kB +14 B (+0.0%)
module 184 kB 184 kB +14 B (+0.0%)
@firebase/auth/internal
Type Base (b5a1a60) Merge (8a4c7b0) Diff
browser 167 kB 167 kB +12 B (+0.0%)
esm5 218 kB 218 kB +14 B (+0.0%)
main 184 kB 184 kB +14 B (+0.0%)
module 167 kB 167 kB +12 B (+0.0%)
@firebase/auth/react-native
Type Base (b5a1a60) Merge (8a4c7b0) Diff
browser 168 kB 168 kB +14 B (+0.0%)
module 168 kB 168 kB +14 B (+0.0%)

`bundle`

Type	Base (`b5a1a60`)	Merge (`8a4c7b0`)	Diff
auth (Anonymous)	67.5 kB	67.5 kB	+12 B (+0.0%)
auth (EmailAndPassword)	71.6 kB	71.6 kB	+12 B (+0.0%)
auth (GoogleFBTwitterGitHubPopup)	94.0 kB	94.0 kB	+12 B (+0.0%)
auth (GooglePopup)	91.2 kB	91.2 kB	+12 B (+0.0%)
auth (GoogleRedirect)	91.5 kB	91.5 kB	+12 B (+0.0%)
auth (Phone)	77.7 kB	77.7 kB	+12 B (+0.0%)

`firebase`

Type	Base (`b5a1a60`)	Merge (`8a4c7b0`)	Diff
firebase-auth-compat.js	126 kB	126 kB	+12 B (+0.0%)
firebase-auth-cordova.js	138 kB	138 kB	+12 B (+0.0%)
firebase-auth-react-native.js	150 kB	150 kB	+12 B (+0.0%)
firebase-auth.js	117 kB	117 kB	+12 B (+0.0%)
firebase-compat.js	747 kB	747 kB	+12 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/uQIxqg6EJU.html

google-oss-bot · 2023-02-15T00:19:39Z

Size Analysis Report ¹

Affected Products

@firebase/auth
- ActionCodeOperation
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.6 kB 31.7 kB +12 B (+0.0%)
  size-with-ext-deps 52.4 kB 52.4 kB +12 B (+0.0%)
- ActionCodeURL
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.5 kB 32.5 kB +12 B (+0.0%)
  size-with-ext-deps 53.4 kB 53.5 kB +12 B (+0.0%)
- AuthCredential
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.7 kB 31.7 kB +12 B (+0.0%)
  size-with-ext-deps 52.4 kB 52.4 kB +12 B (+0.0%)
- AuthErrorCodes
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 36.1 kB 36.1 kB +12 B (+0.0%)
  size-with-ext-deps 56.8 kB 56.8 kB +12 B (+0.0%)
- EmailAuthCredential
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 33.5 kB 33.6 kB +12 B (+0.0%)
  size-with-ext-deps 54.3 kB 54.3 kB +12 B (+0.0%)
- EmailAuthProvider
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 35.0 kB 35.0 kB +12 B (+0.0%)
  size-with-ext-deps 56.0 kB 56.0 kB +12 B (+0.0%)
- FacebookAuthProvider
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 36.6 kB 36.6 kB +12 B (+0.0%)
  size-with-ext-deps 57.3 kB 57.3 kB +12 B (+0.0%)
- FactorId
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.4 kB 31.4 kB +12 B (+0.0%)
  size-with-ext-deps 52.1 kB 52.1 kB +12 B (+0.0%)
- GithubAuthProvider
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 36.6 kB 36.6 kB +12 B (+0.0%)
  size-with-ext-deps 57.3 kB 57.3 kB +12 B (+0.0%)
- GoogleAuthProvider
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 36.6 kB 36.6 kB +12 B (+0.0%)
  size-with-ext-deps 57.3 kB 57.3 kB +12 B (+0.0%)
- OAuthCredential
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 33.7 kB 33.7 kB +12 B (+0.0%)
  size-with-ext-deps 54.4 kB 54.4 kB +12 B (+0.0%)
- OAuthProvider
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 37.5 kB 37.5 kB +12 B (+0.0%)
  size-with-ext-deps 58.2 kB 58.2 kB +12 B (+0.0%)
- OperationType
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.5 kB 31.5 kB +12 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB +12 B (+0.0%)
- PhoneAuthCredential
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 33.7 kB 33.7 kB +12 B (+0.0%)
  size-with-ext-deps 54.4 kB 54.4 kB +12 B (+0.0%)
- PhoneAuthProvider
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 35.3 kB 35.4 kB +12 B (+0.0%)
  size-with-ext-deps 56.1 kB 56.1 kB +12 B (+0.0%)
- PhoneMultiFactorGenerator
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.4 kB 32.4 kB +12 B (+0.0%)
  size-with-ext-deps 53.1 kB 53.1 kB +12 B (+0.0%)
- ProviderId
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.5 kB 31.5 kB +12 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB +12 B (+0.0%)
- RecaptchaVerifier
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 37.9 kB 37.9 kB +12 B (+0.0%)
  size-with-ext-deps 58.6 kB 58.6 kB +12 B (+0.0%)
- SAMLAuthProvider
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 37.8 kB 37.9 kB +12 B (+0.0%)
  size-with-ext-deps 58.6 kB 58.6 kB +12 B (+0.0%)
- SignInMethod
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.6 kB 31.6 kB +12 B (+0.0%)
  size-with-ext-deps 52.3 kB 52.3 kB +12 B (+0.0%)
- TwitterAuthProvider
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 36.6 kB 36.6 kB +12 B (+0.0%)
  size-with-ext-deps 57.3 kB 57.3 kB +12 B (+0.0%)
- applyActionCode
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.6 kB 31.6 kB +12 B (+0.0%)
  size-with-ext-deps 52.3 kB 52.4 kB +12 B (+0.0%)
- beforeAuthStateChanged
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.5 kB 31.5 kB +12 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB +12 B (+0.0%)
- browserLocalPersistence
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 34.8 kB 34.8 kB +12 B (+0.0%)
  size-with-ext-deps 55.6 kB 55.6 kB +12 B (+0.0%)
- browserPopupRedirectResolver
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 55.8 kB 55.8 kB +12 B (+0.0%)
  size-with-ext-deps 76.7 kB 76.8 kB +12 B (+0.0%)
- browserSessionPersistence
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 34.8 kB 34.8 kB +12 B (+0.0%)
  size-with-ext-deps 55.6 kB 55.6 kB +12 B (+0.0%)
- checkActionCode
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.6 kB 32.6 kB +12 B (+0.0%)
  size-with-ext-deps 53.3 kB 53.3 kB +12 B (+0.0%)
- confirmPasswordReset
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.7 kB 31.7 kB +12 B (+0.0%)
  size-with-ext-deps 52.4 kB 52.4 kB +12 B (+0.0%)
- connectAuthEmulator
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 33.1 kB 33.1 kB +12 B (+0.0%)
  size-with-ext-deps 53.9 kB 53.9 kB +12 B (+0.0%)
- createUserWithEmailAndPassword
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.5 kB 32.6 kB +12 B (+0.0%)
  size-with-ext-deps 53.3 kB 53.3 kB +12 B (+0.0%)
- debugErrorMap
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 42.5 kB 42.5 kB +12 B (+0.0%)
  size-with-ext-deps 63.2 kB 63.3 kB +12 B (+0.0%)
- deleteUser
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.4 kB 31.4 kB +12 B (+0.0%)
  size-with-ext-deps 52.1 kB 52.2 kB +12 B (+0.0%)
- fetchSignInMethodsForEmail
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.9 kB 31.9 kB +12 B (+0.0%)
  size-with-ext-deps 52.6 kB 52.6 kB +12 B (+0.0%)
- getAdditionalUserInfo
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.7 kB 32.7 kB +12 B (+0.0%)
  size-with-ext-deps 53.4 kB 53.5 kB +12 B (+0.0%)
- getAuth
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 65.9 kB 65.9 kB +12 B (+0.0%)
  size-with-ext-deps 93.3 kB 93.3 kB +12 B (+0.0%)
- getIdToken
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.4 kB 31.4 kB +12 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB +12 B (+0.0%)
- getIdTokenResult
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.4 kB 31.4 kB +12 B (+0.0%)
  size-with-ext-deps 52.1 kB 52.1 kB +12 B (+0.0%)
- getMultiFactorResolver
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 34.1 kB 34.2 kB +12 B (+0.0%)
  size-with-ext-deps 54.9 kB 54.9 kB +12 B (+0.0%)
- getRedirectResult
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 39.1 kB 39.1 kB +12 B (+0.0%)
  size-with-ext-deps 59.8 kB 59.8 kB +12 B (+0.0%)
- inMemoryPersistence
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.4 kB 31.4 kB +12 B (+0.0%)
  size-with-ext-deps 52.1 kB 52.1 kB +12 B (+0.0%)
- indexedDBLocalPersistence
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 38.8 kB 38.8 kB +12 B (+0.0%)
  size-with-ext-deps 59.5 kB 59.6 kB +12 B (+0.0%)
- initializeAuth
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.7 kB 31.7 kB +12 B (+0.0%)
  size-with-ext-deps 52.8 kB 52.9 kB +12 B (+0.0%)
- isSignInWithEmailLink
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.6 kB 32.6 kB +12 B (+0.0%)
  size-with-ext-deps 53.6 kB 53.6 kB +12 B (+0.0%)
- linkWithCredential
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.4 kB 32.4 kB +12 B (+0.0%)
  size-with-ext-deps 53.1 kB 53.2 kB +12 B (+0.0%)
- linkWithPhoneNumber
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 36.1 kB 36.1 kB +12 B (+0.0%)
  size-with-ext-deps 56.8 kB 56.9 kB +12 B (+0.0%)
- linkWithPopup
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 42.6 kB 42.6 kB +12 B (+0.0%)
  size-with-ext-deps 63.4 kB 63.4 kB +12 B (+0.0%)
- linkWithRedirect
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 37.9 kB 37.9 kB +12 B (+0.0%)
  size-with-ext-deps 58.6 kB 58.6 kB +12 B (+0.0%)
- multiFactor
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 33.6 kB 33.6 kB +12 B (+0.0%)
  size-with-ext-deps 54.3 kB 54.3 kB +12 B (+0.0%)
- onAuthStateChanged
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.5 kB 31.5 kB +12 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB +12 B (+0.0%)
- onIdTokenChanged
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.5 kB 31.5 kB +12 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB +12 B (+0.0%)
- parseActionCodeURL
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.5 kB 32.5 kB +12 B (+0.0%)
  size-with-ext-deps 53.5 kB 53.5 kB +12 B (+0.0%)
- prodErrorMap
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.4 kB 31.4 kB +12 B (+0.0%)
  size-with-ext-deps 52.1 kB 52.1 kB +12 B (+0.0%)
- reauthenticateWithCredential
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 33.0 kB 33.0 kB +12 B (+0.0%)
  size-with-ext-deps 53.7 kB 53.7 kB +12 B (+0.0%)
- reauthenticateWithPhoneNumber
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 36.6 kB 36.7 kB +12 B (+0.0%)
  size-with-ext-deps 57.4 kB 57.4 kB +12 B (+0.0%)
- reauthenticateWithPopup
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 42.6 kB 42.7 kB +12 B (+0.0%)
  size-with-ext-deps 63.4 kB 63.4 kB +12 B (+0.0%)
- reauthenticateWithRedirect
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 37.6 kB 37.6 kB +12 B (+0.0%)
  size-with-ext-deps 58.3 kB 58.4 kB +12 B (+0.0%)
- reload
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.4 kB 31.4 kB +12 B (+0.0%)
  size-with-ext-deps 52.1 kB 52.1 kB +12 B (+0.0%)
- sendEmailVerification
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.4 kB 32.5 kB +12 B (+0.0%)
  size-with-ext-deps 53.2 kB 53.2 kB +12 B (+0.0%)
- sendPasswordResetEmail
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.4 kB 32.4 kB +12 B (+0.0%)
  size-with-ext-deps 53.1 kB 53.1 kB +12 B (+0.0%)
- sendSignInLinkToEmail
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.4 kB 32.4 kB +12 B (+0.0%)
  size-with-ext-deps 53.1 kB 53.1 kB +12 B (+0.0%)
- setPersistence
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.4 kB 31.5 kB +12 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB +12 B (+0.0%)
- signInAnonymously
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.7 kB 32.7 kB +12 B (+0.0%)
  size-with-ext-deps 53.4 kB 53.4 kB +12 B (+0.0%)
- signInWithCredential
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.8 kB 32.8 kB +12 B (+0.0%)
  size-with-ext-deps 53.5 kB 53.5 kB +12 B (+0.0%)
- signInWithCustomToken
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.5 kB 32.5 kB +12 B (+0.0%)
  size-with-ext-deps 53.2 kB 53.3 kB +12 B (+0.0%)
- signInWithEmailAndPassword
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 36.4 kB 36.5 kB +12 B (+0.0%)
  size-with-ext-deps 57.4 kB 57.4 kB +12 B (+0.0%)
- signInWithEmailLink
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 36.7 kB 36.7 kB +12 B (+0.0%)
  size-with-ext-deps 57.6 kB 57.6 kB +12 B (+0.0%)
- signInWithPhoneNumber
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 36.4 kB 36.4 kB +12 B (+0.0%)
  size-with-ext-deps 57.2 kB 57.2 kB +12 B (+0.0%)
- signInWithPopup
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 42.6 kB 42.6 kB +12 B (+0.0%)
  size-with-ext-deps 63.4 kB 63.4 kB +12 B (+0.0%)
- signInWithRedirect
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 37.3 kB 37.3 kB +12 B (+0.0%)
  size-with-ext-deps 58.0 kB 58.1 kB +12 B (+0.0%)
- signOut
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.4 kB 31.4 kB +12 B (+0.0%)
  size-with-ext-deps 52.1 kB 52.1 kB +12 B (+0.0%)
- unlink
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.0 kB 32.0 kB +12 B (+0.0%)
  size-with-ext-deps 52.7 kB 52.7 kB +12 B (+0.0%)
- updateCurrentUser
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.4 kB 31.5 kB +12 B (+0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB +12 B (+0.0%)
- updateEmail
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.7 kB 31.7 kB +12 B (+0.0%)
  size-with-ext-deps 52.4 kB 52.4 kB +12 B (+0.0%)
- updatePassword
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.7 kB 31.7 kB +12 B (+0.0%)
  size-with-ext-deps 52.4 kB 52.4 kB +12 B (+0.0%)
- updatePhoneNumber
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.2 kB 32.2 kB +12 B (+0.0%)
  size-with-ext-deps 52.9 kB 52.9 kB +12 B (+0.0%)
- updateProfile
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.9 kB 31.9 kB +12 B (+0.0%)
  size-with-ext-deps 52.6 kB 52.6 kB +12 B (+0.0%)
- useDeviceLanguage
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 31.4 kB 31.4 kB +12 B (+0.0%)
  size-with-ext-deps 52.1 kB 52.2 kB +12 B (+0.0%)
- verifyBeforeUpdateEmail
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.5 kB 32.5 kB +12 B (+0.0%)
  size-with-ext-deps 53.2 kB 53.2 kB +12 B (+0.0%)
- verifyPasswordResetCode
  Size
  Type Base (b5a1a60) Merge (8a4c7b0) Diff
  size 32.7 kB 32.7 kB +12 B (+0.0%)
  size-with-ext-deps 53.4 kB 53.4 kB +12 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/e34HdvsbXP.html

#7038) * Change _fail to use AuthErrorCode.INTERNAL_ERROR and pass in error messsage * Add changeset

maccman · 2023-03-13T16:06:35Z

@NhienLam we just upgraded to this version and we're seeing our users get logged out whenever the network changes.

Change _fail to use AuthErrorCode.INTERNAL_ERROR and pass in error me…

c7766ea

…sssage

NhienLam requested a review from prameshj February 14, 2023 23:36

NhienLam requested review from lisajian, renkelvin and sam-gc as code owners February 14, 2023 23:36

prameshj approved these changes Feb 14, 2023

View reviewed changes

Add changeset

19b78a6

NhienLam requested a review from egilmorez as a code owner February 15, 2023 00:18

NhienLam requested a review from hsubox76 February 15, 2023 19:18

sam-gc approved these changes Feb 15, 2023

View reviewed changes

NhienLam merged commit c8a6e08 into master Feb 15, 2023

NhienLam deleted the nhienlam-patch-2 branch February 15, 2023 22:07

google-oss-bot mentioned this pull request Mar 1, 2023

Version Packages #7069

Merged

renkelvin pushed a commit that referenced this pull request Mar 2, 2023

Change _fail to use AuthErrorCode.INTERNAL_ERROR and pass in error me… (

5fbcaba

#7038) * Change _fail to use AuthErrorCode.INTERNAL_ERROR and pass in error messsage * Add changeset

maccman mentioned this pull request Mar 13, 2023

Constant auth sign-out/log-out whenever the network changes. #7118

Closed

firebase locked and limited conversation to collaborators Mar 18, 2023

Change _fail to use AuthErrorCode.INTERNAL_ERROR and pass in error me… #7038

Change _fail to use AuthErrorCode.INTERNAL_ERROR and pass in error me… #7038

Conversation

🦋 Changeset detected

Size Report 1

Affected Products

@firebase/auth

@firebase/auth/cordova

@firebase/auth/internal

@firebase/auth/react-native

bundle

firebase

Test Logs

Size Analysis Report 1

Affected Products

@firebase/auth

ActionCodeOperation

ActionCodeURL

AuthCredential

AuthErrorCodes

EmailAuthCredential

EmailAuthProvider

FacebookAuthProvider

FactorId

GithubAuthProvider

GoogleAuthProvider

OAuthCredential

OAuthProvider

OperationType

PhoneAuthCredential

PhoneAuthProvider

PhoneMultiFactorGenerator

ProviderId

RecaptchaVerifier

SAMLAuthProvider

SignInMethod

TwitterAuthProvider

applyActionCode

beforeAuthStateChanged

browserLocalPersistence

browserPopupRedirectResolver

browserSessionPersistence

checkActionCode

confirmPasswordReset

connectAuthEmulator

createUserWithEmailAndPassword

debugErrorMap

deleteUser

fetchSignInMethodsForEmail

getAdditionalUserInfo

getAuth

getIdToken

getIdTokenResult

getMultiFactorResolver

getRedirectResult

inMemoryPersistence

indexedDBLocalPersistence

initializeAuth

isSignInWithEmailLink

linkWithCredential

linkWithPhoneNumber

linkWithPopup

linkWithRedirect

multiFactor

onAuthStateChanged

onIdTokenChanged

parseActionCodeURL

prodErrorMap

reauthenticateWithCredential

reauthenticateWithPhoneNumber

reauthenticateWithPopup

reauthenticateWithRedirect

reload

sendEmailVerification

sendPasswordResetEmail

sendSignInLinkToEmail

setPersistence

signInAnonymously

signInWithCredential

signInWithCustomToken

Size Report ¹

`@firebase/auth`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`bundle`

`firebase`

Size Analysis Report ¹

`@firebase/auth`

`ActionCodeOperation`

`ActionCodeURL`

`AuthCredential`

`AuthErrorCodes`

`EmailAuthCredential`

`EmailAuthProvider`

`FacebookAuthProvider`

`FactorId`

`GithubAuthProvider`

`GoogleAuthProvider`

`OAuthCredential`

`OAuthProvider`

`OperationType`

`PhoneAuthCredential`

`PhoneAuthProvider`

`PhoneMultiFactorGenerator`

`ProviderId`

`RecaptchaVerifier`

`SAMLAuthProvider`

`SignInMethod`

`TwitterAuthProvider`

`applyActionCode`

`beforeAuthStateChanged`

`browserLocalPersistence`

`browserPopupRedirectResolver`

`browserSessionPersistence`

`checkActionCode`

`confirmPasswordReset`

`connectAuthEmulator`

`createUserWithEmailAndPassword`

`debugErrorMap`

`deleteUser`

`fetchSignInMethodsForEmail`

`getAdditionalUserInfo`

`getAuth`

`getIdToken`

`getIdTokenResult`

`getMultiFactorResolver`

`getRedirectResult`

`inMemoryPersistence`

`indexedDBLocalPersistence`

`initializeAuth`

`isSignInWithEmailLink`

`linkWithCredential`

`linkWithPhoneNumber`

`linkWithPopup`

`linkWithRedirect`

`multiFactor`

`onAuthStateChanged`

`onIdTokenChanged`

`parseActionCodeURL`

`prodErrorMap`

`reauthenticateWithCredential`

`reauthenticateWithPhoneNumber`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`reload`

`sendEmailVerification`

`sendPasswordResetEmail`

`sendSignInLinkToEmail`

`setPersistence`

`signInAnonymously`

`signInWithCredential`

`signInWithCustomToken`

`signInWithEmailAndPassword`

`signInWithEmailLink`

`signInWithPhoneNumber`

`signInWithPopup`

`signInWithRedirect`

`signOut`

`unlink`