Replaced capitalize() method to mitigate issue with camelCase flavors #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaibolay
suggested changes
Nov 29, 2022
|
|
||
| public static String capitalize(String s) { | ||
| if (s.length() == 0) return s; | ||
| return s.substring(0, 1).toUpperCase() + s.substring(1).toLowerCase(); |
There was a problem hiding this comment.
I think rewriting this method to just use:
return s.substring(0, 1).toUpperCase() + s.substring(1);
is more reasonable than taking on the dependency on org.apache.commons:commons-lang3 and increases the chances of this getting merged.
davidmotson
pushed a commit
that referenced
this pull request
Jan 17, 2023
also bumped the gradle version to fix incompatibility with more recent JVM and updated groovy enum definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used Apache Commons for the capitalization, which may be unreasonable. So if it's not okay to use Commons, it's possible to rewrite the existing method to not interfere with the camelCase names of the flavors.
I've added a test case for the issue, so you can see that it will fail without the fix.
Also, compilation failed for me because of the
publicmodifier in the enum, so I changed that as well.Closes #183