WorryFree Computers   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1][Events] PageCache event classes #41965

Merged
merged 3 commits into from
Mar 1, 2024
Merged

[5.1][Events] PageCache event classes #41965

merged 3 commits into from
Mar 1, 2024

Conversation

Fedik
Copy link
Member
@Fedik Fedik commented Sep 28, 2023

Summary of Changes

Implementing Event classes for PageCache events.
Affected events:

  • onPageCacheSetCaching
  • onPageCacheGetKey
  • onPageCacheIsExcluded

Testing Instructions

Enable PageCache plugin, make sure cache works as before

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: TBD
  • No documentation changes for manual.joomla.org needed

@Fedik Fedik added the Feature label Sep 28, 2023
@Fedik Fedik changed the title [5.1][Events] PageCache events [5.1][Events] PageCache event classes Sep 28, 2023
@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev September 30, 2023 22:48
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@crommie
Copy link
crommie commented Feb 24, 2024

I have tested this item ✅ successfully on fa45c91

Caching keeps working as should.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41965.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on fa45c91

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41965.

@richard67
Copy link
Member

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41965.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 26, 2024
Fedik and others added 2 commits February 29, 2024 09:48
@Fedik @bembelimen
Update plugins/system/cache/src/Extension/Cache.php
cd0425c 
Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com>
@bembelimen
Merge branch '5.1-dev' into events-pagecache
2f1d2e9
@bembelimen bembelimen merged commit 43e35f6 into joomla:5.1-dev Mar 1, 2024
3 checks passed
@bembelimen
Copy link
Contributor

Thank you!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 1, 2024
@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Mar 1, 2024
@Fedik Fedik deleted the events-pagecache branch March 1, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bembelimen bembelimen bembelimen left review comments

Assignees
No one assigned
Labels
Feature PR-5.1-dev
Projects
None yet
Milestone
Joomla! 5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Fedik @HLeithner @crommie @viocassel @richard67 @bembelimen @joomla-cms-bot