[5.1] Generic doc icon #42527
[5.1] Generic doc icon #42527
Conversation
Replaces the pdf icon used in media manager with a more generic doc icon as this is applied to a variety of doc types. ### To test Use one of the prebuilt packages for this PR and check to see that the icon used in media manager for any doc type is no longer a pdf icon. Changing the icon to a specific one for each type of doc is beyond the scope of this PR
|
The NPM Package (under Download) is not available. |
|
updating branch to see if it will trigger the downloads to be created |
|
@brianteeman #36723 has more icons |
|
but that is closed and as stated
|
@ChristineWk You can find the downloads here: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/42527/downloads/72301/ . Currently there is something broken with updating the links to these downloads on GitHub. |
|
@richard67
|
@ChristineWk Not sure now and no time to check. @brianteeman Do you know why she gets the "No preview" icon for the 2nd case |
|
|
|
An essential part of testing is to replicate the before scenario. As you can see in both my before and after screenshots both show the doc file with first a pdf and then a generic icon your test is not successful for some reason |
|
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42527. |
|
I have tested this item ✅ successfully on 7873ca8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42527. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42527. |
|
Thanks! |
Replaces the pdf icon used in media manager with a more generic doc icon as this is applied to a variety of doc types.
To test
Use one of the prebuilt packages for this PR and check to see that the icon used in media manager for any doc type is no longer a pdf icon.
Changing the icon to a specific one for each type of doc is beyond the scope of this PR
Pull Request for Issue #42518
Before
After
.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed