New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1] Fix user field validation on change #42756

Merged

bembelimen merged 4 commits into joomla:5.1-dev from C-Lodder:user-field-validation

Feb 25, 2024

Member

C-Lodder commented

•

Summary of Changes

This PR fixes error validation on a "User" field when a user is selected.

Testing Instructions

Got to administrator/index.php?option=com_messages&view=messages
Click "New"
Focus on the "Recipient" user input field
Focus away from the "Recipient" user input field (you'll see a red error message)
Select a user

Actual result BEFORE applying this Pull Request

Field remained red with the error message

Expected result AFTER applying this Pull Request

Error message is removed and field border turns green


          Fix user field validation on change

57babee

joomla-cms-bot added NPM Resource Changed PR-5.1-dev labels

Contributor

dgrammatiko commented

I wouldn't add another listener into the validate.js.
FWIW you can fix this issue by replacing this

joomla-cms/build/media_source/system/js/fields/joomla-field-user.w-c.es6.js

Lines 142 to 146 in 4e6d9ea

    
           dialog.addEventListener('joomla-dialog:close', () => { 
        
             window.removeEventListener('message', msgListener); 
        
             dialog.destroy(); 
        
             this.dialog = null; 
        
           });

with this:

    dialog.addEventListener('joomla-dialog:close', () => {
      window.removeEventListener('message', msgListener);
      dialog.destroy();
      this.dialog = null;
      this.inputName.focus();
      this.buttonSelect.focus();
    });

Basically it's a focus delegation problem...

fgsw commented

I have tested this item ✅ successfully on 57babee

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.}


          JS changes

0dabe82

dgrammatiko approved these changes

View reviewed changes

Contributor

viocassel commented

I have tested this item ✅ successfully on 0dabe82

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.}

1 similar comment

fgsw commented

I have tested this item ✅ successfully on 0dabe82

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.}

Contributor

Quy commented

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.}

joomla-cms-bot added the RTC label


          Merge branch '5.1-dev' into user-field-validation

dc0db7f

crimle commented

I have tested this item 🔴 unsuccessfully on dc0db7f

Pressing the button {Apply Patch] results in error message
There are no files to patch from this pull request. This may mean that the files in the pull request are not present in your installation.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.}

Nuyonuyonoina commented

•

"Apply patch" button doesn't work. Error message is "There are no files to patch from this pull request. This may mean that the files in the pull request are not present in your installation."

eddiekonczal commented

I have tested this item 🔴 unsuccessfully on dc0db7f

When I try to install the patch, I get this error:

"There are no files to patch from this pull request. This may mean that the files in the pull request are not present in your installation."

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.}

Member

richard67 commented

•

@crimle @Nuyonuyonoina @eddiekonczal I will reset the negative test results as they are not caused by this PR. The PR modifies an NPM dependency, which can be seen by the label "NPM Resource Changed". Such PRs can't be tested with Patchtester, they require either a development environment with composer and NPM, or they need to be applied by using the packages created by drone, which can be found in the "Downloads" section of the integration checks at the bottom of the PR.


          Merge branch '5.1-dev' into user-field-validation

02e15f3

bembelimen merged commit cc8ef4d into joomla:5.1-dev

0 of 2 checks passed

Contributor

bembelimen commented

Thx

joomla-cms-bot removed the RTC label

bembelimen added this to the Joomla! 5.1.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment