WorryFree Computers   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1] Minor cleanup for modules JS #42784

Merged
merged 2 commits into from
Feb 26, 2024
Merged

[5.1] Minor cleanup for modules JS #42784

merged 2 commits into from
Feb 26, 2024

Conversation

C-Lodder
Copy link
Member

Summary of Changes

As Joomla no longer supports IE11, this PR mainly removes the need for converting a NodeList to an Array, as evergreen browser's implementation of forEach can iterater over a NodeList.

Also includes some other minor tweaks.

image

Testing Instructions

Code review @dgrammatiko @Fedik

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Feb 11, 2024
@Fedik
Copy link
Member
Fedik commented Feb 12, 2024

Looks good from review,
However it would be good to see at least one human test to confirm that the Admin menu still works.

@Fedik
Copy link
Member
Fedik commented Feb 12, 2024

I have tested this item ✅ successfully on e971d1e

Okay, menu seems still working :)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42784.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on e971d1e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42784.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Feb 13, 2024
@alikon
Copy link
Contributor
alikon commented Feb 13, 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42784.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 13, 2024
@alikon alikon added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Feb 13, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 26, 2024
@LadySolveig LadySolveig merged commit 7c45ae8 into joomla:5.1-dev Feb 26, 2024
2 of 3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 26, 2024
@LadySolveig
Copy link
Contributor

Thank you @C-Lodder and for testing @Fedik @viocassel

@brianteeman brianteeman mentioned this pull request Apr 3, 2024
Merged
4 tasks
@richard67 richard67 mentioned this pull request Apr 18, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Milestone
Joomla! 5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@C-Lodder @Fedik @viocassel @alikon @LadySolveig @joomla-cms-bot